ndd7xv / heh

A terminal UI to edit bytes by the nibble.
MIT License
444 stars 18 forks source link

improve search and navigation #58

Closed joooooooooooooooooooooooooooooooooooosh closed 1 year ago

joooooooooooooooooooooooooooooooooooosh commented 1 year ago

This adds some more supplementary shortcuts and overhauls the search functionality to allow wrapping, repeated, and directional search.

ndd7xv commented 1 year ago

Thank you for your contribution :smile: It's really nice to see someone implement some of the features I had in mind when I would (eventually) get to improving search (like the / and n and p)!

I'll try and spend some time this weekend to thoroughly look over this, but at first glance it seems very solid. Thanks again :)

codecov[bot] commented 1 year ago

Codecov Report

Merging #58 (14a696d) into main (1b17492) will increase coverage by 1.3%. The diff coverage is 29.6%.

Additional details and impacted files | [Impacted Files](https://app.codecov.io/gh/ndd7xv/heh/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/app.rs](https://app.codecov.io/gh/ndd7xv/heh/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2FwcC5ycw==) | `0.0% <0.0%> (ø)` | | | [src/input.rs](https://app.codecov.io/gh/ndd7xv/heh/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2lucHV0LnJz) | `0.0% <0.0%> (ø)` | | | [src/main.rs](https://app.codecov.io/gh/ndd7xv/heh/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21haW4ucnM=) | `3.5% <0.0%> (ø)` | | | [src/windows/editor.rs](https://app.codecov.io/gh/ndd7xv/heh/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3dpbmRvd3MvZWRpdG9yLnJz) | `0.0% <0.0%> (ø)` | | | [src/windows/search.rs](https://app.codecov.io/gh/ndd7xv/heh/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3dpbmRvd3Mvc2VhcmNoLnJz) | `47.5% <52.7%> (+9.8%)` | :arrow_up: |
ndd7xv commented 1 year ago

Sorry again for the delays, thanks so much for adding tests and the PR! I think after the other open PR is merged, I'll create a new version with these improved search changes.

It really makes my day to see contributions like this :) merging!