ndeadly / MissionControl

Use controllers from other consoles natively on your Nintendo Switch via Bluetooth. No dongles or other external hardware neccessary.
GNU General Public License v2.0
2.4k stars 137 forks source link

[Feature Request]: Adjust Dualsense bindings #632

Closed ruvaldak closed 9 months ago

ruvaldak commented 1 year ago

Feature Description

set mute button (white button below the PS button) to screenshot, have left touch pad be identical to share/create button, right touch pad identical to options button.

Rationale

Mute button seems to be unused otherwise, and the touchpad is very easy to accidentally press when trying to press start/select (options/share, I guess is their new name).

Additional Details

Could be optional I guess, as an alternative Dualsense layout. As a side note, perhaps look into using the lightbar colors to indicate battery life? Probably unnecessary.

ndeadly commented 1 year ago

Ha, I didn't know that was a button, thought it was just an LED. I will have to check whether this is feasible. I'm not sure if the button actually sends input data back to the console, or whether it just operates locally on the controller.

Regarding the touchpad - for the sake of consistency I would like to keep the behaviour similar to the Dualshock 4, which doesn't have the mute button. I understand the issue of accidentally pressing the touchpad though. A better compromise might be to divide the touchpad into three sections and have, say, the middle 50% continue to operate as capture, and the remaining 25% on both sides act as start/select. I think this would solve your problem of accidental presses while allowing for identical behaviour between the PS4 and PS5 controllers. What do you think?

Could be optional I guess, as an alternative Dualsense layout. As a side note, perhaps look into using the lightbar colors to indicate battery life? Probably unnecessary.

Could be an interesting optional feature to add to the configuration options, but is not something I would prioritise currently.

ruvaldak commented 1 year ago

The middle 50% as a capture button sounds fine to me. Decent compromise!

The Mute button can be bound to other functions on PC clients such as Steam. I'm able to set it to screenshot through steam, as well, so I don't see why it wouldn't work.

ndeadly commented 1 year ago

@ruvaldak this maps the mute button to capture in addition to the touchpad changes I proposed above. Let me know what you think.

MissionControl-0.9.2-sony-touchpad-627a3c2.zip

20excal07 commented 1 year ago

I'd like to add to this suggestion... instead of making the mute button send a simple button press, why not also make it an internal feature toggle instead? And you can even light up the button, when the toggle's active.

You could have users press and hold for 2 seconds to toggle it on or off.

If it's on:

else if it's off:

ndeadly commented 1 year ago

While using the mute button as a toggle of some sort isn't a bad idea, I think the likelihood of someone wanting to change the touchpad behaviour on the fly is pretty low. I think it could better serve some other purpose. E.g indicating the battery level via the LED colour like in @ruvaldak's original suggestion.

If the new behaviour is an issue for you, a better alternative might be to have the percentage of the touchpad dedicated to the share/options button as a configurable option where 0=old behaviour where the whole thing functions as capture, and 50=No capture at all, just split evenly down the middle between +/- buttons.

20excal07 commented 1 year ago

If the new behaviour is an issue for you, a better alternative might be to have the percentage of the touchpad dedicated to the share/options button as a configurable option where 0=old behaviour where the whole thing functions as capture, and 50=No capture at all, just split evenly down the middle between +/- buttons.

I'm okay with that. On an unrelated note, I'm pretty sure the mute button LED only has one colour... or at least, I'm not made aware that you can make it light colours other than amber? :p

ndeadly commented 1 year ago

I'm pretty sure the mute button LED only has one colour

Oh, I was referring to using the lightbar colour. The mute button would just be to toggle or momentarily activate the alternate behaviour

uper333 commented 1 year ago

encio para capturar además de los cambios del panel táctil que propuse anteriormente. Déjame saber lo que piensas.

@ruvaldak this maps the mute button to capture in addition to the touchpad changes I proposed above. Let me know what you think.

MissionControl-0.9.2-sony-touchpad-627a3c2.zip

Wow, thank you very much for this, you can't even imagine the number of captures I've accidentally made in Zelda haha, the only thing that with the ps4 controller (not original) doesn't capture, only the ends work to enter the menus.

Could the touch panel be completely disabled for the dualsense? leaving only the captures in the audio button?

Thank you very much for the work and sorry for my English

20excal07 commented 1 year ago

While we're here again, @ndeadly are there any plans to include this (or any other requested features for that matter) into the next stable release?