search

ndejong / pfsense_fauxapi

REST based API interface for pfSense 2.3.x and 2.4.x to facilitate devops
Apache License 2.0
354 stars 61 forks source link

system_load_config needs to detect proper port for curl exec #31

Closed travisghansen closed 6 years ago

travisghansen commented 6 years ago

Just getting started with this package and noticed it's exec'ing curl like this: curl --silent --insecure \"http:\/\/127.0.0.1\/index.php?__fauxapi_callid=5b8ac08e9846d\

This causes the app to stall for me as I run the webgui on 8080. If we could make that a bit more dynamic that would be great. Thanks!

ndejong commented 6 years ago

@travisghansen - yes, this is a good suggestion.

The the client libraries also need to be separated into their own repos so they can be made into packages for pip and the like.

travisghansen commented 6 years ago

I'll be working on a client library (php) tomorrow FYI. I'll also have an MR for you to fix this issue.

travisghansen commented 6 years ago

@ndejong I've opened an MR for this. Also, I've completed a PHP client: https://github.com/travisghansen/pfsense_fauxapi_php_client

It's available on packagist as well.

ndejong commented 6 years ago

Ahh - most excellent, a PHP client, has been a need for this for quite a while - once I break out the Bash and Python clients from this main repo I'll add pointers to your client - thanks again!

ndejong commented 6 years ago

Merged pull request: https://github.com/ndejong/pfsense_fauxapi/pull/33