New API for network rules

slayercat commented 4 years ago

GET network_address_aliases_get - Returns address aliaes used by rules.
POST network_address_aliases_create - Creates An network aliaes for rules
POST network_address_aliases_update - Update a address aliaes. Returns newest result
POST network_address_aliases_delete - Delete a address aliaes. Returns newest result
GET filter_rules_get - Returns firewall filters.
POST filter_rules_create - Creates firewall filters.
POST filter_rules_delete - Deletes firewall filters.

Closes #50

Korvuss commented 4 years ago

would it be possible to merge this as its exactly what I am currently looking for !

slayercat commented 4 years ago

Hi, @Korvuss

You may want to review issues #56 .

Thanks.

ndejong commented 4 years ago

Hi @slayercat pardon the long delay in my getting to this.

The code is well written, but you are re-declaring the namespace in an unexpected location

This is messy and almost looks as if it is an accidental piece of code that has crept in at development time

Also - can you propose some tests for this? I'll add them to the Python client interface examples that get used in the test harness

ndejong / pfsense_fauxapi