search

ndelitski / rancher-alarms

Will kick your ass if found unhealthy service in Rancher environment
85 stars 20 forks source link

release 0.2.0 #15

Open ndelitski opened 8 years ago

ndelitski commented 8 years ago

Todo

Is there anything i have missed @flaccid?

flaccid commented 8 years ago

Circling back now. From what I can see, the only thing outstanding/desired is https://github.com/ndelitski/rancher-alarms/issues/17 (icon_emoji for slack webhook).

jmreicha commented 7 years ago

It looks like this has been open for awhile. Is there any update on this? Notification for services recovering would be huge.

ndelitski commented 7 years ago

Hello! Thanks for your feedback, I'll try to make this possible during next week On Fri, 28 Jul 2017 at 23:17, Josh Reichardt notifications@github.com wrote:

It looks like this has been open for awhile. Is there any update on this? Notification for services recovering would be huge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ndelitski/rancher-alarms/issues/15#issuecomment-318751898, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7ZWqjbbNAV62GwP_01nCd45Lo-VufEks5sSkHZgaJpZM4JkBHK .

jmreicha commented 7 years ago

@ndelitski Awesome, thanks for the update.

ndelitski commented 7 years ago

@jmreicha Hello just pushed new version with a recover state notification, please check if it works as expected and then we release it. Docker image version is 0.1.8-rc

ndelitski commented 7 years ago

btw recover notifications feature is enabled by default, do we even need it to be an optional?

jmreicha commented 7 years ago

@ndelitski Awesome, I will try to test it out this week. I don't really have a use case for turning off the recovery feature. Thanks again!

jmreicha commented 7 years ago

The recovery notification is working.

The only other thing I'd like to see is red for degraded and green when recovered for Slack messages. I can do a separate PR or just work with the templates for that unless you want to make that default behavior.

jmreicha commented 7 years ago

Woops. There is already an issue for the colors https://github.com/ndelitski/rancher-alarms/issues/24.

ndelitski commented 7 years ago

Ok from what I've read we need to hardcode message color depending on notification type, sounds easy to implement. I'll do it soon 😉 On Wed, 16 Aug 2017 at 21:34, Josh Reichardt notifications@github.com wrote:

I see there is already an issue for the colors #24 https://github.com/ndelitski/rancher-alarms/issues/24.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ndelitski/rancher-alarms/issues/15#issuecomment-322860715, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7ZWpJPohKyu1yztHPbKhi2bUyMx2dkks5sYzY7gaJpZM4JkBHK .