Cannot use a template variable more than once in template

[flaccid]

I assume this is due to the code in render-template.es6:

import _ from 'lodash';
import assert from 'assert';

export default function renderTemplate(template, data) {
  var result = template;

  // interpolate string
  for (let [k,v] of _.pairs(data)) {
    result = result.replace(`#{${k}}`, v)
  }

  // check if not all variables are filled
  let freeVariables = result.match(/#\{(\S+)\}/g);
  assert(!freeVariables, `template has unresolved variables:\ntemplate: ${template}\nmissing variables: ${(freeVariables || []).join(', ')}`);

  return result;
}

For example, I use this in my email template:

                  <tr>
                    <th>Service URL</th><td><a href="#{serviceUrl}">#{serviceUrl}</a></td>
                  </tr>

This will trip returning: missing variables: #{serviceUrl}.

Possible to fix (or do we consider using a template rendering package)?

[ndelitski]

@flaccid yes this is exactly a bug in a template function, will fix it soon! missed global regex flag

[flaccid]

Tested and confirmed also, thanks.