ndepend / ndepend-action

The NDepend GitHub Action
Other
10 stars 2 forks source link

Deprecation notice: v1, v2, and v3 of artifact actions #5

Open togabrennan opened 3 months ago

togabrennan commented 3 months ago

Deprecation notice: v1, v2, and v3 of the artifact actions The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "ndepend", "ndependtrend". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The current way the action is handling artifacts is being deprecated and we're getting warnings in our action executions.

CoderGears commented 3 months ago

Thanks for your valuable feedback, we will soon update our action to use the v4 upload artifact feature.

On Tue, Jun 11, 2024 at 3:06 PM Brennan Hitchcock @.***> wrote:

Deprecation notice: v1, v2, and v3 of the artifact actions The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "ndepend", "ndependtrend". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The current way the action is handling artifacts is being deprecated and we're getting warnings in our action executions.

— Reply to this email directly, view it on GitHub https://github.com/ndepend/ndepend-action/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZI6N3ZRV4R52SWRDMWTZG377VAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DMNJTGQ2TINQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

CoderGears commented 3 months ago

Could you please test the v2 of the ndepend action @.*** It uses the new upload artifact v4 version.

On Tue, Jun 11, 2024 at 3:06 PM Brennan Hitchcock @.***> wrote:

Deprecation notice: v1, v2, and v3 of the artifact actions The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "ndepend", "ndependtrend". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The current way the action is handling artifacts is being deprecated and we're getting warnings in our action executions.

— Reply to this email directly, view it on GitHub https://github.com/ndepend/ndepend-action/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZI6N3ZRV4R52SWRDMWTZG377VAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DMNJTGQ2TINQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

togabrennan commented 3 months ago

I'm not seeing a v2 release?

CoderGears commented 3 months ago

From our github action https://github.com/ndepend/ndepend-action you have the v2 branch [image: image.png]

From your yaml just replace @. with @.

On Tue, Jun 11, 2024 at 10:40 PM Brennan Hitchcock @.***> wrote:

I'm not seeing a v2 release?

— Reply to this email directly, view it on GitHub https://github.com/ndepend/ndepend-action/issues/5#issuecomment-2161644454, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZIZY3LY6AQGLUWTGHPDZG5VEXAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGY2DINBVGQ . You are receiving this because you commented.Message ID: @.***>

togabrennan commented 3 months ago

From our github action https://github.com/ndepend/ndepend-action you have the v2 branch [image: image.png] From your yaml just replace @. with @. On Tue, Jun 11, 2024 at 10:40 PM Brennan Hitchcock @.> wrote: I'm not seeing a v2 release? — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZIZY3LY6AQGLUWTGHPDZG5VEXAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGY2DINBVGQ . You are receiving this because you commented.Message ID: @.>

It looks like your yaml replacement is getting sanitized. All I'm seeing is ***@***.***

CoderGears commented 3 months ago

Yes For some reason the versions are hidden, to make it works replace v1 with v2 for your ndepend action.

[image: image.png]

On Wed, Jun 12, 2024 at 2:10 PM Brennan Hitchcock @.***> wrote:

From our github action https://github.com/ndepend/ndepend-action you have the v2 branch [image: image.png] From your yaml just replace @. with @. … <#m-7172983628866663730> On Tue, Jun 11, 2024 at 10:40 PM Brennan Hitchcock @.> wrote: I'm not seeing a v2 release? — Reply to this email directly, view it on GitHub <#5 (comment) https://github.com/ndepend/ndepend-action/issues/5#issuecomment-2161644454>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZIZY3LY6AQGLUWTGHPDZG5VEXAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGY2DINBVGQ https://github.com/notifications/unsubscribe-auth/ACGKZIZY3LY6AQGLUWTGHPDZG5VEXAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGY2DINBVGQ . You are receiving this because you commented.Message ID: @.>

It looks like your yaml replacement is getting sanitized. All I'm seeing is @.***

— Reply to this email directly, view it on GitHub https://github.com/ndepend/ndepend-action/issues/5#issuecomment-2162973431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZI2EJ62IBBYMPOH7I2TZHBCFRAVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSHE3TGNBTGE . You are receiving this because you commented.Message ID: @.***>

togabrennan commented 3 months ago

That seemed to clear the artifacts warning, but does not resolve the node version in my other PR - https://github.com/ndepend/ndepend-action/pull/3

Can we get a formally released v2 with these fixes?

CoderGears commented 3 months ago

This issue was resolved a long time ago, could you please check which ndepend action is used in your PR and it concerns which date? here's our action.yml using node16 https://github.com/ndepend/ndepend-action/blob/main/action.yml

On Thu, Jun 13, 2024 at 3:47 PM Brennan Hitchcock @.***> wrote:

That seemed to clear the artifacts warning, but does not resolve the node version in my other PR - #3 https://github.com/ndepend/ndepend-action/pull/3

Can we get a formally released v2 with these fixes?

— Reply to this email directly, view it on GitHub https://github.com/ndepend/ndepend-action/issues/5#issuecomment-2165893563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGKZIZYWXN2EW7TPH4MZZDZHGWI3AVCNFSM6AAAAABJENP35WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVHA4TGNJWGM . You are receiving this because you commented.Message ID: @.***>