search

ndevenish / gflabel

Generate 3d-printable labels for gridfinity label systems
BSD 3-Clause "New" or "Revised" License
44 stars 6 forks source link

Updates for Cullenect v2 #8

Open ndevenish opened 3 months ago

ndevenish commented 3 months ago

see: https://github.com/ndevenish/gflabel/issues/7

Incomplete list of changes/TODO:

ndevenish commented 3 months ago

@CullenJWebb I think this is now matching your 2.0.3-beta geometry. The text emboss depth on top doesn't match (is 0.4mm instead of 0.2mm) but at the moment this is configured by argument directly (and not split per-base). I can make it change the text depth by default if you think it is important.

Generating labels with this branch and the new shape:

gflabel cullenect --version=v2.0.3-beta "Label Text"
CullenJWebb commented 3 months ago

This looks excellent. I'm going to do some testing with this.

ostat commented 1 month ago

What do you guys think about supporting changing x (and maybe y) dimensions for both version 1 and version 2 of cullenect ?

The default size for version 1 is 36.4mm with a hole space of 36.7, however if you have a 1 unit length Gridfinity bin with the standard lip you only have 36.3 mm. Which sounds ok, but its too tight. Also someone might want a label for a less than ro greater than 1 unit bin.

I would like to support changing the size of the label in the lip.

For reference. https://github.com/ostat/gridfinity_extended_openscad/issues/53

ndevenish commented 1 month ago

It looks like the issue there is specifically that the gridfinity_extended_openscad changed geometry such that the standard labels don't fit any more?

I'm open to adding the ability to tune the base sizes, as long as the "standard" size is the default. I think it'd be pretty simple to support changing the basic sizes with overrides. It would be easiest just to assume that the click-bars stay in the same relative size/position and the label ends up being whatever custom size on top of that. Does that sound like it would help?

ostat commented 1 month ago

It looks like the issue there is specifically that the gridfinity_extended_openscad changed geometry such that the standard labels don't fit any more?

Support for Cullenect labels, in gridfinity extended was never finalised. I got it kind of working, but never really finalised it (the ticket is still open. The only way I can get the standard size Cullenect labels to fit is to switch the standard lip with the minimised lip, or drop the label below the lip. The bins that are provided with the Cullenect labels, have the equivalent of the minimised lip. So I dont think its possible to support the Cullenect label of 36.7mm on a gridfinity bin with the standard lip enabled. I am option to suggestion if I have missed something.

I'm open to adding the ability to tune the base sizes, as long as the "standard" size is the default. I think it'd be pretty simple to support changing the basic sizes with overrides. It would be easiest just to assume that the click-bars stay in the same relative size/position and the label ends up being whatever custom size on top of that. Does that sound like it would help?

I think keeping the bars in the same position makes sense. Could we keep the pattern going, so after the first bar, a bar is every _n_mm following the current pattern?

I also think that Cullenect labels would be useful for other projects that might want a smaller or larger label

ndevenish commented 1 month ago

I think keeping the bars in the same position makes sense. Could we keep the pattern going, so after the first bar, a bar is every _n_mm following the current pattern?

Like, span all the way to where the next bin would be? I've thought it would be useful to be able to have a multibin-length label, but was reluctant to invent my own modification of what was supposed to be a standard. Could always have it as advanced options, I guess.