ndevenish / miniapp

0 stars 1 forks source link

Implement extended dispersion spotfinding #10

Open dimitrivlachos opened 3 months ago

dimitrivlachos commented 3 months ago

Implement the extended dispersion spotfinding algorithm. This improves the accuracy of the spotfinder by using a first-pass to mask out the potential signal areas from the background calculation before performing a second pass for true signal identification.

graeme-winter commented 3 months ago

Just a note on the implementation here - we would probably like to be able to switch at run time between kernels e.g. mode=dispersion / mode=extended or similar

dimitrivlachos commented 3 months ago

Just a note on the implementation here - we would probably like to be able to switch at run time between kernels e.g. mode=dispersion / mode=extended or similar

I did add the kernel selection as an argument, so it is selectable at run time 😄

Is this implementation acceptable @graeme-winter?

graeme-winter commented 3 months ago

Just a note on the implementation here - we would probably like to be able to switch at run time between kernels e.g. mode=dispersion / mode=extended or similar

I did add the kernel selection as an argument, so it is selectable at run time 😄

Is this implementation acceptable @graeme-winter?

Didn't mean to imply it wasn't there, just thought I would look later but this thought was in my head now ;-) so happy it was preempted