search

ndexbio / ndex-python

NDEx Python Client v3.1 - Superseded by the NDEx2 Client v1.0
2 stars 6 forks source link

Update argument handling in client #17

Closed cthoyt closed 7 years ago

cthoyt commented 7 years ago

Closes #16

I think this is a bit more pythonic, and will be exceptionally useful for the Clarivate team who will want to use this client to send BEL to non-default servers (I will have to wrap PyBEL's export to NDEx function as well to allow for custom host definitions, but that will be easy once this PR is accepted)

cthoyt commented 7 years ago

@dexterpratt @jingjingbic would you be able to accept this pull request, even though development for this repository is switching over to the ndex2 client?

agary-ucsd commented 7 years ago

Hey Charlie, Thanks for contributing to the pythonic-ness of our code. We will make (and accept) small changes to ndex-python in the short term. Your pull request has been merged with the master branch.

Thanks again, Aaron

From: Charles Tapley Hoyt notifications@github.com<mailto:notifications@github.com> Reply-To: ndexbio/ndex-python reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, November 15, 2017 at 4:57 AM To: ndexbio/ndex-python ndex-python@noreply.github.com<mailto:ndex-python@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: Re: [ndexbio/ndex-python] Update argument handling in client (#17)

@dexterpratthttps://github.com/dexterpratt@jingjingbichttps://github.com/jingjingbic would you be able to accept this pull request, even though development for this repository is switching over to the ndex2 client?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ndexbio/ndex-python/pull/17#issuecomment-344584478, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOUrQMPX2ONvPdepO6toJuNzwFBpwt5Vks5s2t-ugaJpZM4PrrvO.