ndexbio / ndex2-client

NDEx2 Client
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Enum issue during Python 3 setup #17

Closed bgyori closed 6 years ago

bgyori commented 6 years ago

There is a subtle issue in setup.py that is causing problems for me in Python 3 on Travis. The problem is with the line: https://github.com/ndexbio/ndex2-client/blob/master/setup.py#L79

'enum; python_version == "2.6" or python_version=="2.7"'

It turns out that when you build a wheel the environment setting gets stripped off. Later, when installing the wheel with pip, the environment setting is not there, and pip tries to install enum even on Python 3, leading to an error.

I am working on a patch for this, I'll submit a PR soon.