search

ndexbio / ndex2-client

NDEx2 Client
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Log folder created in installation folder #26

Closed bgyori closed 5 years ago

bgyori commented 5 years ago

The code here: https://github.com/ndexbio/ndex2-client/blob/master/ndex2/__init__.py#L19-L23 attempts to make a logs directory within the package folder. This doesn't work if the package is installed in a folder (e.g. with sudo pip install) for which the user doesn't normally have write permission. This led me to a situation where I can't import the package due to the folder creation erroring. Is there some way to change this behavior?

bgyori commented 5 years ago

Looks like there is a relevant commit (https://github.com/ndexbio/ndex2-client/commit/7a0e6717b438aae4a0f4de4fe885b0cee51ab6b8) which might solve this, my error was with the version on PyPI which hasn't been released since.

coleslaw481 commented 5 years ago

Hi, Yes I ran into the same issue and have committed a fix. I'll cut a release as soon as I can.

thanks,

chris

coleslaw481 commented 5 years ago

Pushed a release candidate 2.0.1rc4 to PyPI. After a bit more testing will do a formal release.

coleslaw481 commented 5 years ago

2.0.1 has been released with fix to PyPI. Closing ticket, please reopen if there is still an issue.

I noticed there is an ndex2-dev and ndex2-performance repo that are almost identical to the ndex2 repo. Going to probably deprecate these repos since they are confusing. If a release of this fix to those repos is needed please let me know.