search

ndfred / iperf-ios

iPerf 3 library and app for iOS
Other
191 stars 25 forks source link

Results history #30

Open deepumukundan opened 4 years ago

deepumukundan commented 4 years ago

It would be nice to have a results list from previous runs show up so we can compare the results. Also if we can tag each test run with a location (Mostly to compare with previous or to to understand blind spots etc) it would help I think.

I have a very barebones implementation here https://github.com/deepumukundan/iperf-ios/commit/69b52d1976b125c9f9a61a5d9e214ad65f8ad625 but it is in Swift. If you are open to having some Swift (Mostly for the UI part), I can polish up the code a bit and add a persistence via Core Data and create a PR back.

UI for the change IMG_9111

ndfred commented 4 years ago

Oh wow, that looks pretty great! I am not opposed to adding Swift in, though the library should probably stay Objective-C so it is easy to embed into various projects. The UI was always the weakest part of the app so really happy to see you give it some love :)

For persistence I usually prefer plist files for really simple usecases so that is what I would suggest here since there are no relationships and the dataset would be fairly small.

deepumukundan commented 4 years ago

Sure I had only planned to update the UI part with Swift and leave the rest in Objective-C.

I think plist could work, but I was hoping to add search/filtering/deleting one or more results from list later, and that's why thought of Core Data.

I haven't made any changes to the main UI yet, just added a location field. Was just trying some speed tests to measure my wifi coverage in different locations inside home. Did you have any specific thing in mind for the speed test UI? If not can just convert the top section to be a table like the new calendar invite entry screen in iOS.

deepumukundan commented 4 years ago

I can also take care of the foundation for #29 and #19 while making the UI updates (Basically kill the xib, and generate localizable.strings file from the code). Then it would be easier to get it translated into different languages.

ndfred commented 4 years ago

Relevant US App Store review (not looking to monetise the app, just saying there is a bit of demand for it):

This thing is perfect to test speeds on an isolated network and rule out crappy speedtest results. The ONLY gripe I have is you can’t save the results or the app doesn’t record them. Add that and I’ll spend $1.99 on it without issues.

ndfred commented 4 years ago

And another US review:

This app is less than 0.5 MB, and does exactly what it is supposed to do, for free. It recently updated to support dark mode which is a great feature. The only thing that could make this app better would be to enable storing server addresses for quicker recall, and to enable some results history. Other much bulkier (and buggier) apps have these features, but I’m sticking with this one due to the bug free, and streamlined performance of this app.

deepumukundan commented 4 years ago

I know the UI I did is not fancy, but its very much functional. Do you want to try it out in your device few days and if it provides better functionality than the current app, send it to store so that others can also find a use? I have been using it for months found the history really useful.

Any grander UI dreams you have can still be added on to current UI architecture, so that can be added on later.

ndfred commented 4 years ago

I'll give it a try :)

deepumukundan commented 4 years ago

Hi @ndfred, just checking back on this. Were you able to try it out?