Results history, Adaptive UI for Test runner, Settings Screen

ndfred / iperf-ios

iPerf 3 library and app for iOS

Other

191 stars 25 forks source link

Results history, Adaptive UI for Test runner, Settings Screen #31

Open deepumukundan opened 4 years ago

deepumukundan commented 4 years ago

This PR covers a lion's share of https://github.com/ndfred/iperf-ios/issues/30.

I redid the Test Runner UI based on the previous one, mainly changing it to adapt to different screen sizes and also potentially for future Catalyst install.
Added a Settings screen as well to configure some extra functionalities (Maybe the Help button can move here in future).
Added localization support for the screens (Should fix https://github.com/ndfred/iperf-ios/issues/29 and https://github.com/ndfred/iperf-ios/issues/19)
Some perks like test success sounds and haptics

Things which are pending (The above changes were already overwhelming, so wanted to break things out)

Actual persistence to disk (TBD, Currently just saves test results to in-memory array)
Sort/Filtering/Delete for results (Depends on 1)

1-Test Runner 2-Test Results 3-Settings

ndfred commented 4 years ago

Thanks for putting this up! Just want to make it clear it might take me a bit to review all of it, and specifically make sure the performance of the tests are not affected by the UI. This means a bit of profiling and profile-guided optimisations, watching Switch / Objective-C inter and so on. I also want to make sure we stay compatible with iOS as far as reasonable, so will need to review all the UIKit APIs we are using here.

deepumukundan commented 4 years ago

Got busy with work and life. I have fixed some of the comments above. Please review and resolve the ones which seem good. Will take a look at the pending ones once I have some time

deepumukundan commented 4 years ago

Most comments taken care of. Please check and let me know. I am pausing for a bit for you to review but in my local usage and tests everything looks good.

ndfred commented 4 years ago

Thanks for keeping at it! It might take a bit for me to go through this again, and I also have a pending iperf library update that I need to fix a couple bugs in, so please don't take it personally if this languishes a bit. What do you think about taking this as a separate branch until it all settles down?

deepumukundan commented 4 years ago

Thanks for keeping at it! It might take a bit for me to go through this again, and I also have a pending iperf library update that I need to fix a couple bugs in, so please don't take it personally if this languishes a bit. What do you think about taking this as a separate branch until it all settles down?

No worries. Take your time. It is serving my current needs of saving results and being able to track speeds over time, so all is good.

Since my changes are on the fork, it should be as good as being in another branch right?

deepumukundan commented 3 years ago

@ndfred Updated with latest master.

deepumukundan commented 3 years ago

@ndfred Just checking back. Let me know if this is needed anymore or if long term plans for the UI have changed.