ndiego / block-visibility

Conditional visibility controls for all WordPress blocks.
https://www.blockvisibilitywp.com
GNU General Public License v2.0
123 stars 10 forks source link

After updating to 3.0.0, the plugin does not detect translations in Editor #68

Closed Gierand closed 1 year ago

Gierand commented 1 year ago

Description

Does not detect translation to other languages in the Site/Post/Page Editor. On the settings page everything works fine.

Step-by-step reproduction instructions

  1. Add sample translated files to the directory: /wp-content/languages/plugins/block-visibility-de_DE.mo /wp-content/languages/plugins/block-visibility-de_DE-2b47503f90344d6580630a5c3c521589.json /wp-content/languages/plugins/block-visibility-de_DE-528469e0eb827b69963521f596eeae41.json
  2. Check Editor if the translation has been detected.

System information

ndiego commented 1 year ago

Thanks for reporting @Gierand, I'll look into it! 💪

ndiego commented 1 year ago

Fixed in v3.0.1.

Gierand commented 1 year ago

Thank you!

Gierand commented 1 year ago

@ndiego, Yet another little thing. The string "Custom Sets" does not have a text domain.

bv

ndiego commented 1 year ago

You are 100% correct. That string is missing a text domain 🤦‍♂️ I'll get that fixed up in the next release.