search

ndiego / icon-block

Effortlessly add SVG icons and graphics to your website.
https://nickdiego.com/projects/icon-block/
GNU General Public License v2.0
104 stars 14 forks source link

Avoid loss of hyphens and colons in attribute names #5

Closed stokesman closed 2 years ago

stokesman commented 2 years ago

To fix #3. I ran into the issue and this was the quickest fix I found. I'm not sure why but html-react-parser will mangle those attributes and this gets around with a little addition to the replace option.

I've not tested it extensively but works well for all the icons I've tried so far.

ndiego commented 2 years ago

Thanks for this @stokesman! I will test this week.

ndiego commented 2 years ago

This works great in my testing. Thanks for taking the time to submit a PR. Merging this now and this fix will be included in the next release coming out tomorrow. 🙌