search

ndiego / icon-block

Effortlessly add SVG icons and graphics to your website.
https://nickdiego.com/projects/icon-block/
GNU General Public License v2.0
110 stars 15 forks source link

Blocks are broken in WordPress 5.8 #9

Closed t-hamano closed 2 years ago

t-hamano commented 2 years ago

Thanks for the great plugin.

I put it on WordPress 5.8 and found that when I click on the "Brouse icon Library" button, the block breaks.

Please see:

https://user-images.githubusercontent.com/54422211/152667774-d316a50d-0974-40e0-bdce-5772b8d7dd16.mp4

I think this is because the SearchControl component has not been implemented in WordPress 5.8.

The SearchControl component was implemented in Gutenberg 11.1.0, but the version of Gutenberg included in WordPress 5.8 is 10.7.

So you might want to replace it with a component such as TextControl if you will support WordPress 5.8.

ndiego commented 2 years ago

Hi @t-hamano, thank you for pointing this out! We plan to use additional functionality in 5.9, therefore I will push a release later this week with the new WordPress version requirement. If you prefer to use the 5.8 compatible version, I just attached the production ready v1.0.0 zip to the release: https://github.com/ndiego/icon-block/releases/tag/v1.0.0.

I also wanted to note that the current version will work with 5.8 as long as you also have the Gutenberg plugin active, but of course this is not the ideal scenario for all users.

t-hamano commented 2 years ago

Thanks for the reply. I will update my WordPress version to 5.9 and am looking forward to the new release of the plugin!

ndiego commented 2 years ago

The latest release is now available so closing this out.