Open Butanium opened 4 months ago
@Butanium
I'm not getting the error you posted, but instead a maximum recursion error.
I need to have a better error for this, but how things work now you can't send arbitrary objects to the server.
It has to be one of: list dict tuple int, string, None, float, bool Tensor slice whitelisted function nnsight Node
You can see this here: https://github.com/ndif-team/nnsight/blob/main/src/nnsight/pydantics/format/types.py
Hi, sorry I posted the wrong trace, I got a recursion error too 😅 I'll look into it
So if I understand correctly, as every stopping criteria is a different class inheriting StoppingCriteria it might not be possible for nnsight to support this argument on remote execution ?
So if I understand correctly, as every stopping criteria is a different class inheriting StoppingCriteria it might not be possible for nnsight to support this argument on remote execution ?
Yeah ndif/nnsight works with a custom serialized format. So it only supports types we explicitly define. Otherwise anyone could execute arbitrary code with arbitrary classes. If StoppingCriteria seems quite useful maybe I could add it.
Stopping criteria is an abstract class meant to be inherited. If I understand correctly you'd need to manually add a set of class inheriting StoppingCriteria right ?
Remote execution does not support stopping_criteria right now:
Error trace: