Add Ellipses as valid type for remote execution

ndif-team / nnsight

The nnsight package enables interpreting and manipulating the internals of deep learned models.

https://nnsight.net/

MIT License

400 stars 37 forks source link

Add Ellipses as valid type for remote execution #139

Closed JadenFiotto-Kaufman closed 5 months ago

francescortu commented 5 months ago

Hi, I'm working on it and https://github.com/francescortu/nnsight/commit/77f10053ad28afe4b646ba91ff80d659fb8fe44f should work. However since the server doesn't have the EllipsisType, it currently raises an error ( I guess it isn't able to compile the EllipsisType since it doesn't know what is it). Is it reasonable?

JadenFiotto-Kaufman commented 5 months ago

@francescortu Looks perfect! I would use Ellipsis instead of type(...). And yeah NDIF will have to be built with the version of nnsight that includes this change. If you wanted to you could build a dev version of NDIF with the nnsight version pointed at your nnsight version: https://github.com/ndif-team/ndif