ndimatteo / HULL

💀 Headless Shopify Starter – powered by Next.js + Sanity.io
https://hull.dev
MIT License
1.38k stars 173 forks source link

@reach/rect error #140

Closed FawnHux closed 6 months ago

FawnHux commented 6 months ago

Hello!

Within the past week, when redeploying our HULL-adapted project with Vercel we encountered this error: Could not resolve dependency: npm ERR! peer react@"^16.8.0 || 17.x" from @reach/rect@0.18.0. I checked your base files and they are the same react@18.2.0 / @reach/rect@0.18.0. It's odd as previously worked fine. For now we have just applied the overide in the package, but good to know if anyone else is experiencing this or has used a different package.

ndimatteo commented 6 months ago

Seems like something has degraded with this package, and unfortunately, it's no longer maintained.

I've switched to using @wellyshen's package for measuring refs: https://github.com/wellyshen/react-cool-dimensions

It's a quality package that is suited to replace most instances of @reach/rect 🤘

Hopefully that helps! And as a friendly reminder– I'm working on a new version of HULL (largely a rewrite), and as a result not actively updating the current version unfortunately. Stay tuned!

manoxs commented 1 month ago

Overwritting the npm install to yarn install did the build for me image