search

ndless-nspire / Luna

Create TNS files from Lua and XML
Other
57 stars 13 forks source link

Default to older file header unless there is a .bmp (Follow-up on #11) #13

Closed adriweb closed 1 year ago

adriweb commented 1 year ago

Updated/Fixed version of ndless-nspire/Luna@6f9fa1b (#11)

Ugly but seems to work?

Vogtinator commented 1 year ago

IMO the version can be treated as a single uint16_t with the MSB for the major and the LSB for the minor version. That's how it looks in the file anyway.

adriweb commented 1 year ago

IMO the version can be treated as a single uint16_t with the MSB for the major and the LSB for the minor version. That's how it looks in the file anyway.

Ah well, probably, but it doesn't matter too much... does it? :P I guess you have edit rights on the PR files anyway 👀

adriweb commented 1 year ago

nice

Vogtinator commented 1 year ago

Feel free to test again with the changes. Here it looks ok.

adriweb commented 1 year ago

Well, converting a .lua file worked fine (and resulted in a 0500 as expected), but converting a simple .bmp (./luna test.bmp test.tns ?) generated a 0700 but triggered an error while trying to open it in TINCS...

I feel like just having a bmp as input isn't enough though, so hopefully that's why :) Don't we have some test xmls somewhere to try this :D

Vogtinator commented 1 year ago

I feel like just having a bmp as input isn't enough though, so hopefully that's why :) Don't we have some test xmls somewhere to try this :D

The ndless 3.9.1 installer uses two BMPs

adriweb commented 1 year ago

Found something else, works fine in TINCS :)