search

ndleyton / OneTwo

MIT License
15 stars 4 forks source link

Dev #14

Open dcutullic opened 4 years ago

dcutullic commented 4 years ago

I want to use your application to choose player's position but when a player release finger order is lost.

I added some code to keep display of selected players even if any player release finger. Added a reset button to launch another choose session

EmberHeartshine commented 4 years ago

It may be more worth it to fork. @ndleyton does not appear active on GitHub.

ndleyton commented 4 years ago

Hi! I'm so sorry. I've been through a lot and left my github projects for a while. I'll check it out right away, thanks!

Also, I'll try to revive this project given the quarantine, if you have any more suggestions

ndleyton commented 4 years ago

HI! I've tried it and I think it's a bit counterintuitive how nothing changes when you take off your fingers. Would you be fine with the results showing up up until all fingers are gone? @dcutullic

EmberHeartshine commented 4 years ago

Having the selection stick and implementing a way to reset it afterward would be a little more helpful (as described by @dcutullic), I think. If my finger's in the way I can't always see what the selection was in the first place.

dcutullic commented 4 years ago

Hi, Thanks for your response. I think it's a good thing than the results don't disappear even when all fingers are gone. I'm agree it could be counterintuitive, maybe it's possible to display a popup to incite to click on the reset button. Or flash briefly the reset button when all fingers are gone. I will develop these improvements and send you an other version in few days.

I'm thinking about some others improvements : dices pools, specific dives (with pictures), game score log, bigger score display.

Le jeu. 9 avr. 2020 à 21:48, EmberHeartshine notifications@github.com a écrit :

Having the selection stick and implementing a way to reset it afterward would be a little more helpful, I think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ndleyton/OneTwo/pull/14#issuecomment-611720136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONPUIZDW4TIBVTOCWM37CTRLYRBFANCNFSM4KN5QMLQ .