search

ndlibersa / resources

**DEPRECATED** MOVED TO https://github.com/Coral-erm/Coral
GNU General Public License v3.0
9 stars 19 forks source link

Upgrade CORAL to use mysqli instead of deprecated mysql #36

Closed remocrevo closed 8 years ago

remocrevo commented 9 years ago

This warning is included on all php.net documentation about mysql functions:

"This extension is deprecated as of PHP 5.5.0, and will be removed in the future. Instead, the MySQLi or PDO_MySQL extension should be used. See also "MySQL: choosing an API" guide and related FAQ for more information."

benheet commented 9 years ago

how much of an effort will this be?

remocrevo commented 9 years ago

The initial conversion of the code could be quick (there is even a utility to help with it), but it would require thorough testing. If a few people could commit to helping, and if someone could guide the testing to make sure all significant database functions were tested, it could move fairly quickly.

PaulPoulain commented 9 years ago

Le 13/04/2015 14:26, remocrevo a écrit :

The initial conversion of the code could be quick (there is even a utility to help with it https://github.com/philip/MySQLConverterTool), but it would require thorough testing. If a few people could commit to helping, and if someone could guide the testing to make sure all significant database functions were tested, it could move fairly quickly.

And here, the words "unit tests" and "jenkins" come to my mind (but this is NOT a quick & easy goal. But a worth one ;-) )

Paul Poulain, Associé-gérant / co-owner BibLibre, expert du logiciel libre pour les bibliothèques BibLibre, Open Source software for libraries expert

jeffnm commented 9 years ago

I have some programmer hours available this summer that could tackle the mysql to mysqli conversion, but as was mentioned previously, testing is going to be time consuming. Are there any objections to my team making the mysqli updates and putting them on a new branch for testing?

remocrevo commented 9 years ago

Sounds good, @jeffnm. Thanks for working on this.

coraladmin commented 9 years ago

@jeffnm how is this effort going?

jeffnm commented 9 years ago

The changes have been made and the pull requests came in from Derek. I think it would be wise if one other institution installed and tested them just to make sure that they are working as expected. If I can get one other institution to test each of the modules and comment to that effect, I'll go ahead and merge them.

On Fri, Jun 19, 2015 at 1:34 PM, coraladmin notifications@github.com wrote:

@jeffnm https://github.com/jeffnm how is this effort going?

— Reply to this email directly or view it on GitHub https://github.com/ndlibersa/resources/issues/36#issuecomment-113599784.

remocrevo commented 9 years ago

Fixed by pull request #48

remocrevo commented 9 years ago

I was wrong. Pull request #48 was closed because it contains errors and needs to be redone. This issue should remain open until a new pull request is merged to fix the problem.

jeffnm commented 8 years ago

https://github.com/ndlibersa/resources/pull/55 was merged to fix this.