Upgrade CORAL to a modern version of jQuery

ndlibersa / resources

**DEPRECATED** MOVED TO https://github.com/Coral-erm/Coral

GNU General Public License v3.0

9 stars 19 forks source link

Upgrade CORAL to a modern version of jQuery #37

Open remocrevo opened 9 years ago

remocrevo commented 9 years ago

We need to upgrade CORAL to use a newer version of jQuery, and we need a plan for staying up to date.

PaulPoulain commented 9 years ago

Shouldn't we use the CDN instead of embeding jquery ? Using <script src="//code.jquery.com/jquery-VERSION.min.js"></script> gives us a handy way to get the jquery version we want quickly.

We currently use the 1.4.4 it seems, we could have the following plan:

use the CDN for 1.4.4 and remove the old jquery
update to a newer version (and fix any problem)

Remington, if you agree with this proposal, I can do it (& do a pull request)

remocrevo commented 9 years ago

@PaulPoulain yes, you are welcome to work on updating CORAL's version of jQuery. It looks like the calendar/date-picker is using an old custom plugin, so you should probably convert it to use whatever is normal in jQuery now. Thanks for offering!

remocrevo commented 9 years ago

And yes, I think the CDN is probably fine. I can see possible benefits to including the jQuery code with CORAL so that each site hosts it themselves, but I don't know enough about it to make a recommendation.

PaulPoulain commented 9 years ago

there's no real pro for hosting jquery yourself (that I know), and there are some cons:

Using CDN mean that your browser will load jquery once only for all the applications that use (this version) of jquery. Otherwise, each app load one. speed improvement.
Using CDN mean you get the fastest access you can imagine, because it's optimized for delivering this content.

jeffnm commented 9 years ago

I'm in favor of using a CDN.

coraladmin commented 9 years ago

That's three votes for CDN so it might as well proceed.