search

ndlibersa / resources

**DEPRECATED** MOVED TO https://github.com/Coral-erm/Coral
GNU General Public License v3.0
9 stars 19 forks source link

Session abstraction #68

Closed billdueber closed 8 years ago

billdueber commented 8 years ago

I was having problems with session files not being unlocked when I needed them, resulting in waits of 30s for some of the Ajax calls. One solution (that allows you to stick with the file-based sessions) is to close the session for writing except for when you actually need to write it.

These changes localize the session stuff to a class (CoralSession.php) that takes care of opening sessions and closing them for writing (leaving them read-only) to avoid this.

This is a pretty big structural change, but I thought I'd at least get a ball in the air and start a discussion.

PaulPoulain commented 8 years ago

Hi billdueber. A general comment: we need a test plan. As described, I'm not completely sure to be able to test your patch & say "OK, it work".

A test plan is something like:

PaulPoulain commented 8 years ago

I tried to move this PR to the merged repo (https://github.com/Coral-erm/Coral), but got many conflicts during the merge, I don't understand what's happening.

PaulPoulain commented 8 years ago

OK, I found my mistake (a tiny one, with large consequences...)

https://github.com/Coral-erm/Coral/pull/2 now contain this pull request on merged repositories. Closing this PR