Closed Phlogistique closed 8 years ago
Looking at the pool test, I don't think I'd consider this a pass - it's not built into the build system, so you won't get features like being able to run other rules that don't depend on the pool at the same time - it's direct blocking of parallelism. Adding a note that tools like sem
can generally be used to fake some of the pool features is probably a good idea, but then I'm not sure there is much benefit to the build tools showing that.
Going through the rest, I see examples/.noleftover-tup.swp
is in the commit - I assume that's a mistake?
It's indeed a mistake.
As for the pool test, I agree.
On Tue, Feb 16, 2016 at 9:55 PM, Neil Mitchell notifications@github.com wrote:
Looking at the pool test, I don't think I'd consider this a pass - it's not built into the build system, so you won't get features like being able to run other rules that don't depend on the pool at the same time - it's direct blocking of parallelism. Adding a note that tools like sem can generally be used to fake some of the pool features is probably a good idea, but then I'm not sure there is much benefit to the build tools showing that.
Going through the rest, I see examples/.noleftover-tup.swp is in the commit - I assume that's a mistake?
— Reply to this email directly or view it on GitHub https://github.com/ndmitchell/build-shootout/pull/24#issuecomment-184871717 .
Noé Rubinstein.
I've merged and made some of the tweaks discussed above.
I'm experimenting with a build on Travis, but will have to see how it goes.
@Phlogistique - I'm having some difficulty installing Gup on Travis - any recommendations? I tried installing 0install from the apt-get command but that didn't work. Is that the best way to go?
Well, I installed it from Nixpkgs so I can not really provide help on this one. I guess the Gup author would be happy to fix the 0install script if it does not work?
On Sun, Feb 28, 2016 at 10:55 AM, Neil Mitchell notifications@github.com wrote:
@Phlogistique https://github.com/Phlogistique - I'm having some difficulty installing Gup on Travis - any recommendations? I tried installing 0install from the apt-get command but that didn't work. Is that the best way to go?
— Reply to this email directly or view it on GitHub https://github.com/ndmitchell/build-shootout/pull/24#issuecomment-189832699 .
Noé Rubinstein.
It's actually installing 0install that is giving me the troubles...
Well, under Debian, "apt install 0install-core" seems to work fine for me, and "0install run http://gfxmonk.net/dist/0install/gup.xml" runs as expected
On Tue, Mar 1, 2016 at 9:19 PM, Neil Mitchell notifications@github.com wrote:
It's actually installing 0install that is giving me the troubles...
— Reply to this email directly or view it on GitHub https://github.com/ndmitchell/build-shootout/pull/24#issuecomment-190885018 .
Noé Rubinstein.
Thanks for the patch! Looks pretty good, but I'll have to wait til tomorrow to actually test it.