Improvements - Githubissues

ndmitchell / debug

Haskell library for debugging

BSD 3-Clause "New" or "Revised" License

122 stars 7 forks source link

Improvements #34

Closed pepeiborra closed 6 years ago

pepeiborra commented 6 years ago

Fixed build with GHC 8, but the instrumentation in the Hoed case does not type check. This is presumably due to flaky support for generation of type signatures inside TH declaration splices.
Refactored the Variables backend to a module and renamed Debug.Record to Debug.DebugTrace (couldn't think of any better name).
Other minor refactorings and fixes.

ndmitchell commented 6 years ago

Looks good, although I'll wait for the CI's to confirm.

ndmitchell commented 6 years ago

Appveyor is failing on Weeder:

== Section test:debug-hoed-test ==
Excessive other-modules entry
* Util
Redundant build-depends entry
* aeson
* bytestring
Weeds exported
* Util
  - equivalentTrace

pepeiborra commented 6 years ago

These are all due to conditional compilation.

EDIT: I was too lazy to record 2 versions of the trace, one for GHC 8.0 without the quick sort bits, and one for GHC 8.2, so I disabled the trace regression tests in GHC 8.0.

ndmitchell commented 6 years ago

If you add them as ignored in the weeder config file, then it should pass.

pepeiborra commented 6 years ago

I've restored the trace regression test in 8.0, should be fine now but let's wait and see