Add the guarded function (lifting into Alternative via predicate)

[memowe]

I'd like to add the guarded function, which I often need. It is well known by relude or Protolude.

I was able to run the test suite and I added documentation including code examples, which should lead to auto-generated tests, but I was unable to run Generate.hs in my GHC 9.4.7 environment. Any hints?

TODO

• [x] Implement the function
• [x] Write haddock
• [x] Include testable code in haddock
• [x] Check with @ndmitchell if it's the correct namespace
• [x] Maybe also add guardedA?
• [x] Auto-generate tests

[memowe]

Regarding my problems to auto-generate the tests:

[memowe@rakete haskell-extra]$ runghc Generate.hs

Generate.hs:6:1: error:
    Could not load module ‘Data.List.Extra’
    It is a member of the hidden package ‘extra-1.7.14’.
...

Full error log

However, building and testing the current test suite works fine.

[memowe]

Hi there! Any feedback is much appreciated. :)

[ndmitchell]

Sorry for the delay in replying. I think this would be a good addition. Adding guardedA seems sensible too. https://github.com/ndmitchell/extra/blob/master/Generate.hs now has documentation on how to run it which works (newer Cabal sandboxing means the old version no longer works) - does that work for you?

[memowe]

Awesome, I'll check right now. :)

[memowe]

https://github.com/ndmitchell/extra/blob/master/Generate.hs now has documentation on how to run it which works [...] - does that work for you?

Thanks! Yes, it works now, although I had to manually

λ :set -package quickcheck-instances

[memowe]

I think this should be ready to merge. Is there anything I can do to help? :)

[memowe]

Any news? 😮

[ndmitchell]

Sorry, I kind of fell off the face of the planet as other things became quite busy in life. Apologies for the delay - the code looks great and I'll make a release with it in shortly.

[memowe]

No worries, thank you so much for taking time to merge this. <3