ndmitchell / extra

Extra Haskell functions
Other
94 stars 37 forks source link

Make it build with ghc-9.12 #114

Closed erikd closed 2 weeks ago

erikd commented 1 month ago

ghc-9.12 has not even had a release candidate yet, nor has the ghc been forked.

I I try to built extra with current ghc@HEAD I need this.

Thanks for the pull request!

By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.

erikd commented 1 month ago

ghc-9.12 has now been branched. The code in this PR still builds.

Bodigrim commented 1 month ago

@erikd I'm afraid it's not that straightforward, see https://github.com/ndmitchell/extra/issues/112 for discussion.

ndmitchell commented 2 weeks ago

Thanks for the PR, I've done something a bit different so that we have the same API on all versions of extra. I'll make a release of this shortly.