Improvements for emacs

[yoricksijsling]

I found the emacs mode quite buggy. These are the changes I've been using locally for a while now.

The window creation behaviour has changed, you can recover the old behaviour by putting the following in your init.el:

(add-to-list
 'display-buffer-alist
 '(\"*ghcid*\"
   (display-buffer-reuse-window   ;; First try to reuse an existing window
    display-buffer-at-bottom      ;; Then try a new window at the bottom
    display-buffer-pop-up-window) ;; Otherwise show a pop-up
   (window-height . 18)      ;; New window will be 18 lines
   ))

Improvements:

• Don't assume that nlinum-mode is available.
• Respect user configuration when displaying the buffer. Now it works with purpose-mode and custom display-buffer-alists
• Automatically detect height of ghcid window.
• Use the standard with-selected-window to temporarily select the ghcid window.
• Use term-line-mode instead of term-char-mode, so the usual navigation shortcuts work in the ghcid buffer.
• Resets the directory of the ghcid process if you call ghcid again.
• Fix bug where the next-error would not always go the the right place in a file.

Thanks for the pull request!

By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.

[ndmitchell]

@WraithM - can you review? Totally out of my depth here.

[wraithm]

@ndmitchell This is great! It works so much better than my version.

Thanks @yoricksijsling. Well done!

[ndmitchell]

Thanks!