ndmitchell / hlint

Haskell source code suggestions
Other
1.45k stars 194 forks source link

hlint incorrectly suggests renaming shadowed "map" when generalise group is on #1572

Open isovector opened 4 months ago

isovector commented 4 months ago

Given

- group: {name: generalise, enabled: true}

hlint will suggest the following illegal transformation:

- test map = map
+ test map = fmap

The fix is to fully qualify the following:

https://github.com/ndmitchell/hlint/blob/8bd116cc7a3fcabf309cb9c1b9aa35016c190b09/data/hlint.yaml#L1125

to

    - warn: {lhs: Data.List.map, rhs: fmap}