search

ndmitchell / hlint

Haskell source code suggestions
Other
1.45k stars 194 forks source link

Amoral language #1591

Open NorfairKing opened 2 months ago

NorfairKing commented 2 months ago

Fix #1584

I started by refactoring the relevant code, but in doing so I found some very strange semantics, as you'll see below. I assume this is a historical artifact of previous refactors but I'd appreciate a double-check first.

I couldn't figure out how to run the tests either, stack test doesn't seem to run any tests.

googleson78 commented 2 months ago

Regarding running tests - https://github.com/ndmitchell/hlint#how-to-run-tests

NorfairKing commented 2 months ago

@googleson78 Aha nice! I just did that and it passed:

Tests passed (956)

But I'd like to do a bit more refactoring because the current code is definitely strange.

NorfairKing commented 1 month ago

@ndmitchell what do you think?