ndmitchell / hlint

Haskell source code suggestions
Other
1.45k stars 194 forks source link

Add hints to use comparing #1603

Open josephcsible opened 2 weeks ago

josephcsible commented 2 weeks ago

This test is failing: https://github.com/ndmitchell/hlint/blob/e0f532a0b958e23044175706b611e45b5aa06889/data/hlint.yaml#L1581 It wants just this to fire: https://github.com/ndmitchell/hlint/blob/e0f532a0b958e23044175706b611e45b5aa06889/data/hlint.yaml#L117 But now "Use comparing" fires too. I'm not sure what the cleanest way to fix this is. What is isCompare doing in that rule exactly?