search

ndmitchell / hlint

Haskell source code suggestions
Other
1.48k stars 195 forks source link

`within` changes the behavior of `modules: {as: }` #1615

Open parsonsmatt opened 2 months ago

parsonsmatt commented 2 months ago

We want to gradually become consistent with our naming of Data.List.NonEmpty, so we create an hlint rule:

- modules:
    - name: [Data.List.NonEmpty] 
      as: NE

I run hlint on our codebase to get all the currently failing examples, and I create a within to ignore them:

- modules:
    - name: [Data.List.NonEmpty] 
      as: NE
      within: [ ... ]

But now it starts complaining about importing Data.List.NonEmpty at all. It seems like within is causing it to ignore the as: key.