search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
753 stars 137 forks source link

add support for --info to search command #153

Closed luntain closed 8 years ago

ndmitchell commented 8 years ago

Thanks! Looks perfect.

One very minor indentation issue, but sufficiently minor that I'm happy to leave it and if one day I'm working nearby I'll change it, and if not, I don't care super much. More a note for any future pull requests you submit :)

luntain commented 8 years ago

I was trying to maintain the fours spaces indent, must have forgotten and reverted to my habits of 2 spaces. Should have changed the editor settings.

On Sun, Feb 21, 2016 at 9:41 PM, Neil Mitchell notifications@github.com wrote:

Thanks! Looks perfect.

One very minor indentation issue, but sufficiently minor that I'm happy to leave it and if one day I'm working nearby I'll change it, and if not, I don't care super much. More a note for any future pull requests you submit :)

— Reply to this email directly or view it on GitHub https://github.com/ndmitchell/hoogle/pull/153#issuecomment-186910667.

luntain commented 8 years ago

Just had a second look at the code, there's just on line indented with 2 spaces. The rest may look off because the else's are one space off because the project compiles with Haskell98. Anyway, thanks for the tool!

On Sun, Feb 21, 2016 at 9:49 PM, Kamil Dworakowski kamil@dworakowski.name wrote:

I was trying to maintain the fours spaces indent, must have forgotten and reverted to my habits of 2 spaces. Should have changed the editor settings.

On Sun, Feb 21, 2016 at 9:41 PM, Neil Mitchell notifications@github.com wrote:

Thanks! Looks perfect.

One very minor indentation issue, but sufficiently minor that I'm happy to leave it and if one day I'm working nearby I'll change it, and if not, I don't care super much. More a note for any future pull requests you submit :)

— Reply to this email directly or view it on GitHub https://github.com/ndmitchell/hoogle/pull/153#issuecomment-186910667.

ndmitchell commented 8 years ago

Yep, I was just referring to that one line, I appreciate the silly if/then indentation is required.