search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

enable support for IPv6 #159

Closed kuk0 closed 8 years ago

kuk0 commented 8 years ago

screen shot 2016-02-23 at 2 18 28 pm

again, i'll make sure i port this also to hoogle5 i also tried an ipv6-only option but when testing it ("!6"), hoogle was still accessible via ipv4 - i'm not sure whether that's a bug in some of the networking libraries...

ndmitchell commented 8 years ago

If I were doing this I'd have added a flag --host which lets you set the host to bind on - sometimes you want to bind on the external IP, sometimes on 127.0.0.1. The fact it supports special values such as !4 might be useful to some people, so they can be available on different IP versions if they want, but generally I imagine people who want to take such control care about the precise host, not just filtering to an IP version. Any reason to not go that route?

kuk0 commented 8 years ago

yup, makes sense... i've updated the commit; fun bash stuff - people will have to use --host='!6', not "!6" because exclamation mark...

ndmitchell commented 8 years ago

Thanks, that looks great. I think bash people using Hoogle already know all about shell escaping - the number of times I've done hoogle a -> b and created the file b...