search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
753 stars 137 forks source link

Make downloaders quiet #17

Closed horus closed 11 years ago

horus commented 11 years ago

Hi,

c.f. PR#18.

I was running the command 'hoogle data', since wget's not available on my machine, so here's the sample of somewhat anonying output:

/bin/sh: wget: command not found -- this line repeats. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3334 100 3334 0 0 4951 0 --:--:-- --:--:-- --:--:-- 4946 /bin/sh: wget: command not found % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 503k 100 503k 0 0 100k 0 0:00:04 0:00:04 --:--:-- 133k

So here's my effort of silencing the downloaders, hopefully it will make the output more clearer.

Cheers, H.

ndmitchell commented 11 years ago

Thanks for the patch. Do you really need to pass -s/-q and also pipe the errors to nul? I'd be much happier only doing -s, since the errors will presumably be useful to anyone trying to debug why it fails?

horus commented 11 years ago

My first attempt was to turn the 'command not found' error off, and you're right, error messages would be helpful when solving problems. I will try to modify again to make it better. Thanks for the reply!

horus commented 11 years ago

I've made some changes after considering your suggestion. The error messages now got printed out with '-S' (curl), and '-nv' (wget). If wget's not available, a warning will be printed once. Also, I changed the download behavior. Let me know if there's anything I can do to improve the code further (if not spamming it :-)