search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
753 stars 137 forks source link

Look for local .cabal files when generating fpco/stackage-server#214 #196

Closed snoyberg closed 7 years ago

snoyberg commented 7 years ago

Good call

On Tue, Nov 29, 2016, 2:44 PM Neil Mitchell notifications@github.com wrote:

@ndmitchell requested changes on this pull request.

One minor tweak

In src/Action/Generate.hs https://github.com/ndmitchell/hoogle/pull/196#pullrequestreview-10525949 :

 packages <- map (takeBaseName &&& id) . filter ((==) ".txt" . takeExtension) <$> concatMapM listFilesRecursive dirs
  • cabals <- concatMapM listFilesRecursive dirs >>=

The listFilesRecursive should be done once and shared breed packages and cabals, since it can be relatively expensive.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ndmitchell/hoogle/pull/196#pullrequestreview-10525949, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB41MdzF2sPOFjm1YM4BTmodaoBWnks5rDB4-gaJpZM4K-3Lr .

ndmitchell commented 7 years ago

Thanks for those changes, it all looks great. I added a few minor tweaks on top, but nothing major. Let me know if you want a release, or if running off a git hash is equally easy for you.