Closed hvr closed 11 years ago
I'm guessing the loss of getList makes loading up documentation and displaying it slower. But since loading up documentation is relatively quick compared to searching, and searching doesn't really store any strings, I suspect it doesn't matter. I agree that moving to Text for these pieces would be a much nicer solution.
The previous implementation of
instance Store Char
silently truncated all Unicode code points to 8-bit. This commit extends the implementation to use UTF8 encoding for storingChar
values (resulting in the same on-disk format for pure ASCII identifiers). The actual UTF8 encoding is provided by thetext
package which is added to the build dependencies.Note: Due to the UTF8 encoding, the getList implementation couldn't be retained in the previous form. However, the long-term solution should be to switch to using
Text
instead of[Char]
for serializing text strings anyway, which can then be simply serialized as UTF8 encoded ByteStrings.