search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Exposing unHTML #210

Closed wz1000 closed 7 years ago

wz1000 commented 7 years ago

We needed unHTML for Haskell IDE Engine.

ndmitchell commented 7 years ago

My concern is that this function is pretty hacky, so I'm not too keen on exposing it... If you really need it then it needs a clear comment saying what it does, and advising that it's a hack, rather than a robust solution.

wz1000 commented 7 years ago

@ndmitchell how about this? I avoided exposing unHTML by breaking up some of the logic of actionSearch into two functions that I expose instead.

ndmitchell commented 7 years ago

That looks much more plausible. I'll review in detail tonight, but happy with the approach.

ndmitchell commented 7 years ago

Thanks, all looks very good. I've made a release to Hackage. Let me know if you need anything further.