ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Change layout/style to adapt on Ocean theme #22

Closed mhitza closed 11 years ago

mhitza commented 11 years ago

As the suggestion in the reddit chat, inside are the changes necessary to have the Ocean theme on Hoogle as well.

ndmitchell commented 11 years ago

Sadly the file src/Web/Page.hs is autogenerated, so you can't modify it directly. The right place to modify is datadir/resources/template.html. Once you modify there if you run hoogle server --dynamic --template=datadir/resources/template.html it will show you Hoogle using the template, and if you run ghci in the root (so you pick up the Hoogle .ghci file) you can type :template to rebuild the template including the changes.

It's my fault that the file Page.hs doesn't have an auto-generated marker on it, so I've just committed code to add that. I hope that syncing the changes back to template.html will be pretty easy, sorry for the hassle.

I also noticed a few visual things that need tweaking:

Thanks for your work so far, looks good!

mhitza commented 11 years ago

Regarding to your first point (and last, as they both are subjective), it does look out of place if the top bar doesn't span across the screen, yet again from my perspective 20px doesn't seem much (maybe using a mobile device would).

And as far as the logo goes, I don't think it is that much of an issue.

:thumbsup:

ndmitchell commented 11 years ago

On a mobile device the top bar takes the entire top of the screen anyway, so you don't lose anything. I'm still reluctant to lose those 20px, but will have a play and see - thanks for the updates.

ndmitchell commented 11 years ago

I played around some more, and it didn't seem too bad. I'm going to squish some of the margins around each entry (they take up a bit too much space to my eye), but overall looks good. I probably won't deploy until the weekend.