search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

allow haskell-src-exts 1.19 #232

Closed imalsogreg closed 6 years ago

imalsogreg commented 6 years ago

Hello! Are you willing to allow this kind of CPP compatibility shimming?

ndmitchell commented 6 years ago

I tend not to bother supporting multiple HSE's unless they can be done with no changes, because testing at each version is a bit of a pain and the MIN_VERSION stuff doesn't work in GHCi (can be worked around, but more workarounds is more pain).

Is there some reason you want the loser bounds? If it provides you with benefit then I'm happy enough.

imalsogreg commented 6 years ago

Thanks for catching my mistakes! I should have remembered you keep your CONTRIBUTING.md in a central place. I've made the changes you suggested, and tested that the hseToSig function I was changing works for the changed constructor (TyInfix) under HSE at both 1.91.1 and 1.21.1, in ghci. I've rebased my branch with that change.

As for whether this patch helps anyone, it is at the tail end of a yak shave, and I've asked upstream ( https://github.com/NixOS/nixpkgs/pull/32947#issuecomment-353439480 ) whether this is in fact necessary. I don't have any specific need for more flexible HSE bounds except for this one. So I can probably answer the question of whether this patch is useful to us or not sometime Wednesday.

ndmitchell commented 6 years ago

Wow, your yak must be mostly bald by now. I'll merge and release later today (just need to find my laptop charger cable first!)

ndmitchell commented 6 years ago

Merged, and I made a release of 5.0.16, which I suspect will be required for you to finish off your epic quest. Good luck!

imalsogreg commented 6 years ago

Thank you very much! Please feel free to ping me if this causes any maintenance burden down the road, I'd be happy to help relieve annoyance there :)