search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Prefix Target html index with a 's' #276

Closed meck closed 5 years ago

meck commented 5 years ago

Fixes #275

meck commented 5 years ago

@ndmitchell I can't really see why this is failing. The failing test is for mapM here.

 query "(a -> m b) -> t a -> m (t b)" -- see GitHub issue #218
            [ InTop 10 ("traverse" `inPackage` "base")
            , InTop 10 ("mapConcurrently" `inModule` "Control.Concurrent.Async.Lifted")
            , InTop 10 ("mapM" `inPackage` "base")
            , InTop 50 ("forM" `inPackage` "base")
            ]

If I loosen it to top 20 it passes all tests, Somehow changing the name of the index changed the ordering of the results?

matt-noonan commented 5 years ago

@meck I don't think this is due to your change, see https://github.com/ndmitchell/hoogle/issues/274.

Feel free to mark any one of them that has started to fail as an expected failure, and I'll clean it up again when I fix that other issue.

matt-noonan commented 5 years ago

That test should pass again once https://github.com/ndmitchell/hoogle/pull/277 is merged.

ndmitchell commented 5 years ago

Thanks!