search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Empty action attribute #330

Closed mhitza closed 4 years ago

mhitza commented 4 years ago

The dot in the action fields creates URLs like /./?hoogle= when the form is submitted (without JavaScript). Those URLs return 404's

Thanks for the pull request!

By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.

ndmitchell commented 4 years ago

It works for me with Google Chrome on Windows either way round - I assume you are on a different browser? Both ways work for me though, so I'll take your fix and hopefully fix some people.

ndmitchell commented 4 years ago

And thanks for the patch!

mhitza commented 4 years ago

I actually just randomly used hoogle with lynx (just to keep all info in my terminal pane) and that's how I found the issue. I just assumed it was an issue with JavaScript disabled.