search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Widen Name type to Word32 #339

Closed kenta2 closed 4 years ago

kenta2 commented 4 years ago

Partially addresses issue https://github.com/ndmitchell/hoogle/issues/335.

Thanks for the pull request!

By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.

ndmitchell commented 4 years ago

The database is versioned by the first 3 digits of the version number of Hoogle. By bumping the 3rd digit it just works out. No need to make an upgrade strategy, it's fine for people to just regenerate. I'm wondering if performance changes measurably with type queries? And I also note there is a test failure - but it's possible that was just because the test barely worked, and with spreading over a wider range of values with bits, something got clipped to a specific value one bit higher/lower and broke - if so fine to disable the test, as long as its not causing lots of breakages.

ndmitchell commented 4 years ago

Thanks! I did some benchmarking and it had nearly no differences, so happy to keep that.