search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Add Missing Files for Tests #366

Open ezzieyguywuf opened 3 years ago

ezzieyguywuf commented 3 years ago

Thanks for the pull request!

By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.

ndmitchell commented 3 years ago

Thanks for the PR - seems good. I note that PR check says:

"Warning: Packages using 'cabal-version: 2.0' and the autogenerated module"
"Paths_* must include it also on the 'autogen-modules' field besides"
"'exposed-modules' and 'other-modules'. This specifies that the module does not"
"come with the package and is generated on setup. Modules built with a custom"
"Setup.hs script also go here to ensure that commands like sdist don't fail."
"Warning: Hackage would reject this package."

And my CI fails because of those warnings. Can they be addressed?

ezzieyguywuf commented 3 years ago

Thanks for the PR - seems good. I note that PR check says:

"Warning: Packages using 'cabal-version: 2.0' and the autogenerated module"
"Paths_* must include it also on the 'autogen-modules' field besides"
"'exposed-modules' and 'other-modules'. This specifies that the module does not"
"come with the package and is generated on setup. Modules built with a custom"
"Setup.hs script also go here to ensure that commands like sdist don't fail."
"Warning: Hackage would reject this package."

And my CI fails because of those warnings. Can they be addressed?

I'll look into this, thanks for the quick review.

ezzieyguywuf commented 3 years ago

@ndmitchell it seems the latest failure has to do with your neil tool. It thinks the License is wrong.

I will point out - I had to reword the LICENSE: stanza when I upgraded the cabal version, could it be that your neil tool needs to be updated itself?

ndmitchell commented 3 years ago

Yep, seems like I might need to adjust the neil tool - and likely all the licenses if this is the new accepted way to write BSD3. I'll try and get to that tonight or tomorrow.

ezzieyguywuf commented 3 years ago

Yep, seems like I might need to adjust the neil tool - and likely all the licenses if this is the new accepted way to write BSD3. I'll try and get to that tonight or tomorrow.

If you give me a list of the licenses you plan to change, I don't mind submitting PR's. I have a feeling that some others of your projects have some missing test files and I don't mind doing the leg work to add it to the release tarball.

ndmitchell commented 3 years ago

Annoyingly, Cabal requires a newer version to enable BSD-3-Clause, and then that stops it working with older versions that support global installs. If we just stick to the addition of misc/sample-data/**/*.txt in data-files, are we able to ignore all the other changes with autogen-modules and the cabal-version? I appreciate I'll have to upgrade to a newer Cabal one day, but the longer I can wait the less porting of workflows I need to do.

ezzieyguywuf commented 3 years ago

I'll have to get rid of ** and manually list each sub dir.

I suppose this is probably less annoying than the alternative that you've proposed?

ndmitchell commented 3 years ago

Yep, that seems a lot less annoying than the alternative, unfortunately - I think the number of directories is fairly limited?

ezzieyguywuf commented 3 years ago

Yea it's notsobad, just verbose.