search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Rewrite local links in Haddock documents #5

Closed khorser closed 11 years ago

khorser commented 11 years ago

Hi, here is the patch implementing issue #568 on google code

ndmitchell commented 11 years ago

Thanks for the patch, I'll take a closer look hopefully by Friday and merge it then. Thanks a lot!

khorser commented 11 years ago

I didn't realize how pull requests work (I thought they work on revision level) so I accidentally added another change: it adds support for --local option when building database for ghc.

ndmitchell commented 11 years ago

I'm happy with both changes, so have included all of them. I also updated the changelog: 949f5166109303a0ccdc591ce0e5a83c733103ba

I believe pull requests work either by specifying a branch (master), or a commit id (e68c3df9852fd2f3563024964da4836d9b589400). I think the standard github method would be for you to create a branch for the change, me and you to discuss it, you commit any modifications on that branch (and they'd show up here), then me to mege. However, I'm not too fussed so whatever works best for you. Thanks for the changes!

khorser commented 11 years ago

Thanks