search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

deprecated settingPort and settingsOnException #75

Closed rdesfo closed 10 years ago

rdesfo commented 10 years ago

hello,

I added setOnException and SetPort to silence some warnings when building hoogle.

ndmitchell commented 10 years ago

Thanks for the patch. Is the intention to remove a deprecation warning with newer versions of WAI/Warp? I've added a couple of comments in two places, which I think are needed to make it compile/test/install successfully.

rdesfo commented 10 years ago

sorry, about the cabal file that should be fixed now.

I didn't think far enough ahead to check if 3.0 was implemented. I believe setPort and setOnException are from version 2.1.

I'll look into 3.0 and see if I can roll it into this patch as well

ndmitchell commented 10 years ago

Yep, I think upgrading to setPort and setOnException is definitely the right thing to do - I think the change probably works cleanly on both 2.1 and 3.0

rdesfo commented 10 years ago

it build and 'cabal test' passed with wai: 3.0.2 installed so I don't think there are any changes that are required for wai/warp 3.0

ndmitchell commented 10 years ago

Awesome - all looks good to me! Thanks for the patch.