search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
738 stars 134 forks source link

Please ship original (non-minified) jquery sources #77

Closed iustin closed 9 years ago

iustin commented 10 years ago

This creates a problem for the Debian packaging, as the minified sources are not considered the "preferred form of modification". We workaround it by shipping ourselves the original sources, but it would be better if the upstream archive already contains it.

ndmitchell commented 10 years ago

I had similar discussions with @nometa in https://github.com/ndmitchell/shake/issues/100 - basically I don't think it's useful to my users, but if it's useful to Debian, I'm happy to dump something in the tarball if you send me a patch. However, it occurs to me that if there was a Haskell library jquery, with the two functions getJQuery :: IO String (get the jQuery source) and getJQueryFile :: IO FilePath` (find where I put it) then both Shake and Hoogle (and likely lots of other libraries) could depend on it. The Debian team could then package one single library with whatever constraints you need (you could even have one of you guys write the package) and you'd probably save work in the long run.

iustin commented 10 years ago

I see. The problem is not only about jquery - you're using also jquery-cookie (but you're shipping that non-minified, so it's good for now), so it would have to be a slightly more generic solution.

Let me think on how this would work for both normal Cabal/Hackage use and Debianized packages.

ndmitchell commented 10 years ago

The plugins that people layer on top are far simpler and far smaller, so not much of an issue. If the Haskell JQuery package wanted to ship 100 common plugins then it could easily do with barely any increase in size and no increase in dependencies.

ndmitchell commented 9 years ago

Fixed in the next version (which is currently at https://github.com/ndmitchell/hogle) by using the js-jquery package on Hackage, which ships the sources properly. All other jQuery addins are shipped unminified.