search

ndmitchell / hoogle

Haskell API search engine
http://hoogle.haskell.org/
Other
753 stars 137 forks source link

Add `--no-download` flag for easier/better packaging #79

Closed iustin closed 10 years ago

iustin commented 10 years ago

This should address (partially) issue #76 (the pre-download step is the remaining part).

I've modified the existing test, although I'm not sure if I've done it right, but cabal test passes (both with and without --no-net).

ndmitchell commented 10 years ago

Looks plausible. I'm not too fussed about the test part either way. The current tests are insufficient, and I will be redoing them at some point. I made one comment on the diff.

iustin commented 10 years ago

Can't comment on the diff from Android, so writing here: yep, I also thought about changing wget, was not sure if you're fine with changing its signature. Will update the patch later in the weekend and let you know when it's ready. Thanks for the feedback!

ndmitchell commented 10 years ago

I don't mind you changing wget, so it's up to you, but it does given the maximum level of robustness - I'm happy either way.

iustin commented 10 years ago

OK, patch updated, but the Travis CI failed due to "cabal update" timing out; I don't know how to re-trigger it (except by pushing a no-op git commit --amend or similar), probably you have a project admin console or such. Let me know what you think about this version!

ndmitchell commented 10 years ago

Cool, all looks good now. Indeed, I have a "refresh" button on Travis, and pressing that fixed everything.

ndmitchell commented 10 years ago

BTW, please let me know if you'd like a release containing that so you can package it, or if there is anything else you want to wait for.

iustin commented 10 years ago

Thanks for the merge - all is fine now. I don't think it's worth making a release just for this, I'll import the patch into Debian until the next upstream release.